[Hyper-v platform] Delete disks on deletion of VM #3616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiliDeng
reviewed
Jan 26, 2025
|
@LiliDeng please let me know if anything is needed on this. |
LiliDeng
reviewed
Jan 28, 2025
lisa/tools/hyperv.py
Outdated
| # above command returns a list of disks if there are multiple disks. | ||
| # if there is only one disk, it returns a single disk but not a list. | ||
| # so convert the output to a list if it is not already a list | ||
| if not isinstance(output, List): |
There was a problem hiding this comment.
if not output:
return []
if not isinstance(output, list):
output = [output]
There was a problem hiding this comment.
@LiliDeng Please let me know if anything more is needed on this?
When a VM is deleted, its attached disks are not automatically removed, which can lead to disk space issues. This change will address the problem by ensuring that both the OS and data disks attached to the VM are deleted across all storage controllers on VM deletion.
SRIKKANTH
force-pushed
the
smyakam/hyperv/cleanup_improvements_26_01_2025
branch
from
85ca87b to
0ed59d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a VM is deleted, its attached disks are not automatically removed, which can lead to disk space issues. This change will address the problem by ensuring that both the OS and data disks attached to the VM are deleted across all storage controllers on VM deletion.